I created a PR literally a few hours after Dotazured added someone to the awards list.
Also, the point of creating a PR is so that people don't have to "sit in the basement coding all day". Go educate yourself instead of sitting in your basement trolling all day.
EDIT: and users like that ^ are the reason I didn't really want to share. Ungrateful and pretentious.
Comment has been collapsed.
how about you shut your mouth? fine you want to make a plugin that makes SG easier to use, but you also want to strip it of some of its functions.. that means its no longer SG+ so call it something else, i for one wont be supporting your endeavors with that attitude
oh and hai!
Comment has been collapsed.
...What the hell is your problem? I'd understand your comments if the OP called the other guys lazy or something like that but he didn't. He just stated that they didn't maintain it and that he didn't get a response which is simple statement of how things went. And yes, perhaps he should call it something different but your apparent offence at him not doing so is kinda weird. Your whole attitude towards this is weird man...
Comment has been collapsed.
Not really an alternative, Just a LibreSG+ to the OpenSG+.
Comment has been collapsed.
Well I tried using it since I was hoping you'd fixed a couple of the bugs I'd been experiencing, but it didn't work for me. Running it in Chrome through Tampermonkey. It installs on top of the other SG Plus Alternative and then doesn't hook into the site at all.
Comment has been collapsed.
Same situation here. I tried your script (after removing the old SGPA) both through tampermonkey and as an extension, in both cases the following error pops up in the console:
Uncaught TypeError: Cannot set property 'reverse' of undefined steamgifts-plus.min.js:113
Running Chrome 33.0.1736.2 beta-m and Tampermonkey 3.6.3737 (latest). Happy to help test this if you'd like, drop me a line on steam.
Edit: issue link
Comment has been collapsed.
There's the full and the minified one.
https://github.com/psyren89/release/tree/master
Comment has been collapsed.
Yeah apparently I had a brainfart earlier today facepalm
I installed both the minified and full version as both chrome extension and via Tampermonkey. Only the minified code throws the error, so I'm guessing you might have to check your minifier. Most likely you need to relax the optimization a bit - not every compiler is perfect with every piece of code, particularly with the toughest optimizations.
Comment has been collapsed.
Normally when it's because of the site being slow, the loading animation will play, but nothing ever appears. I'll see this quite often on the main page, where endless scrolling works. There's no such loading animation on forum pages though.
Comment has been collapsed.
Thats what i noticed when i initially looked at it, why not just implement the change i posted?
or try putting the dropdown div first, it seems to do the trick
Comment has been collapsed.
It can always be separated into another file and maintained separate to the meat of the code. For now, it's still in there (with a few bugs, I think. Another user who forked Dotazured's fork changed a couple of things pertaining to the awards code, but I haven't merged his changes into my code).
Comment has been collapsed.
see its not separate, its a feature we've all come to know. Just saying if you want people to use your addon should probably have all the features the original has. Considering i dont see anything wrong with the original, anything with less than that isnt really worth it.
Comment has been collapsed.
While it's probably not a big deal, personally I don't use awards/tagging and I'm guessing there are others like me, and I strongly support optimizing these little things where it's reasonable to do so. If the choice is purely between removing it or keeping it, then it should be kept, but if it wouldn't be too much work to manage two versions (or to split the tagging stuff into a separate, compatible addon) then that seems like the best thing to do.
Comment has been collapsed.
I'm just going to say that whoever fixes the horrible mess that are Game Filters is going to be a hero.
(By fixing I mean automatically removing games that are in the owned list, removing horizontal scrollbars, sorting by alphabet, making all the entries equal width, and possibly introducing a search box.)
Comment has been collapsed.
This shit here: http://i.imgur.com/BLAdfP7.png
(Pay no attention to the lack of a visible horizontal scrollbar and a weird vertical scrollbar here, because Chrome is fucked up starting from version 32; the developers decided to take lots of drugs and completely change how scrollbars have worked for the past thirty years. See https://code.google.com/p/chromium/issues/detail?id=279464 for more info.)
Comment has been collapsed.
If you want a quick way to do this consider something like Isotope(jQuery plugin) or Packery(standalone library) - they're both great solutions for the bin-packing problem (arranging various items to fill a container).
Alternatively you can have a look at the respective codes and use that to create your own solution. This might be better if you're concerned about adding an entire plugin/library to solve this minor issue.
Comment has been collapsed.
I think you missed the point entirely :)
The point is to make that list of filtered games usable and navigable. Currently it's not. It's a huge mess. The data visualization plugins you linked to aren't suitable for the purpose - exactly the contrary.
For example, recently I acquired Tomb Raider and wanted to remove DLCs from the filter. I had to go through that list five times, each one taking a solid two minutes. I'm still not sure if I have removed everything. In the end I realized it would have been easier to import/export and edit in a text editor.
Comment has been collapsed.
Yeah, I guess I focused more on the presentation aspect. However, Isotope supports alphabetical sorting. If the overall intent is to keep the filter "list" presented as a collection of rectangular elements then Isotope would be an easy way to sort it and make it look neater.
Perhaps making the items fixed-width and allowing for variable height (via text wrapping) would allow for better presentation when sorted. Making the container area resizeable (as you suggested) would also be effortless with Isotope without impacting the layout/sorting.
Regardless, this is just a tip. There are many ways to deal with that "list". Turning it into a regular list is another possibility (perhaps in a 2- or 3-column layout).
Comment has been collapsed.
The same thing happens in Chrome without any monkeys.
Comment has been collapsed.
I'm using Chrome (Iron, based on Chromium 31), Tampermonkey. This is what I get:
http://puu.sh/6pcue.png
Comment has been collapsed.
I get the same thing as PE99 on his linked picture, i.e. two columns and no scrolling bars.
Comment has been collapsed.
I think you are talking about two different places, where this list appears.
psyren has a screenshot about the setting when clicking on "Filter Settings" on the startpage of SG.
PE and Jengonthanda are referencing to the "Giveaway Preferences" tab on the settings page.
Comment has been collapsed.
It's a JS file, not an actual extension. I don't have the knowledge to create a Chrome/FF extension, and I've read a couple of articles that argue having things as dedicated scripts is better on memory usage since the scripts are only loaded when they're needed, instead of at browser start.
Something to investigate, maybe.
Comment has been collapsed.
Why does it have to have the same name as the regular one?
(You can't have them both on FF at the same time and disable/swap between them, it's just replacing the other)
edit: after manually switching, your script doesn't do anything at all. Maybe it conflicts with other scripts I use for this site and doesn't load.
Comment has been collapsed.
Is there any updates to this one?
Might just keep the old one(until is stops working).
Comment has been collapsed.
^ this is what I'm doing. This alternative alternative appears to have less features (not more) and additional issues with chrome. Original alternative continues to work just fine
Comment has been collapsed.
I agree, the alternative works fine.
Removing functionality just because you don't like it is a bad plan. If anything, make it an option if you feel like it slows down the site for you. (Though I doubt it unless you have a computer that isn't able to run games in the first place)
Comment has been collapsed.
I was following all this from far, and i decided today to check it.
I compared the different versions of the script we can found nowadays.
Yours have nothing LESS, you even corrected some typos, and a DLC List more up to date.
So, thank you.
Comment has been collapsed.
The User tag function is very useful for me. That helps people who lacks of an amazing memory.
Comment has been collapsed.
In case anyone cares, I've got a fairly decently sized update in the works.
tl;dr, should bring about some performance improvements (both speed and memory use) and fix a bug with DLC filtering (it'll probably get a few hiccups, but will make DLC filtering more consistent and reliable).
Long version:
I've sanitised (lower cased and removed all non-word characters) and ordered the DLC (games and their DLC) list manually so that this doesn't have to be done at run time (toLowerCase() calls are no longer needed, which should be an O(# of DLC * average length of DLC name) improvement in performance, if I remember my complexity analysis lectures correctly).
I've updated the DLC list with more entries (I've been doing this anyway), and removed F2P games from the list. The reasoning for this is that everyone "owns" F2P games, so a lot of DLC for F2P games were being erroneously filtered. I've also cleaned up a lot of crap/incorrect entries (a few "Uninitialised" items appeared here and there).
Since the DLC list is now ordered, a binary search can be used when the script needs to check games against the library/DLC filter list. This will take comparison time down from O(# of items in list) to O(log(# of items in list)).
Comment has been collapsed.
Thanks for doing this! I'm looking forward to your updates!
Comment has been collapsed.
209 Comments - Last post 9 minutes ago by drschnell
421 Comments - Last post 39 minutes ago by Wok
60 Comments - Last post 1 hour ago by Microfish
1,351 Comments - Last post 1 hour ago by Microfish
556 Comments - Last post 1 hour ago by Microfish
10 Comments - Last post 2 hours ago by medion
79 Comments - Last post 3 hours ago by romana1994
45 Comments - Last post 25 minutes ago by Axelflox
108 Comments - Last post 39 minutes ago by WarlordFred
605 Comments - Last post 43 minutes ago by RomeFM
38 Comments - Last post 1 hour ago by thoughtfulhippo
104 Comments - Last post 1 hour ago by supremeentity
98 Comments - Last post 1 hour ago by reigifts
44 Comments - Last post 2 hours ago by Exodust
AS OF THE NEWEST CHROME VERSION (35), THE SCRIPT HAS BROKEN DUE TO SECURITY FEATURES.
PLEASE REINSTALL THE SCRIPT OR EDIT THE SAVED SCRIPT INSTALLER TO POINT TO http://psyren89.github.io/release/steamgifts-plus.min.js
Is anyone interested in using my fork of SGP?
A little while ago, Kaitlyn's hosting for SGP died. A couple of guys here copied the code and put up their own copy of it. They didn't maintain it, however, and I got no response when I asked to be added to the repo as a contributor so I could keep stuff up to date, and there's also been no response on my pull request to update the DLC list.
I forked their code and am now hosting my own. I've fixed a couple of bugs in the code, set up CI to run the JS through the Closure compiler automatically (for minification), and I'm keeping the DLC list as up to date as I can.
If you want to fix bugs, you'd be welcome to pull down the code and make pull requests.
Since at least one user wants to see it, here are some installation instructions:
Download this (Chrome users right click -> Save Link As).
Firefox users, run it through Greasemonkey.
Chrome users, download it to local storage, then drag and drop it into the Tools -> Extensions window or run it through Tampermonkey.
You should be good to go after that. It'll use the same settings/storage as SGP/A if you're already using it.
EDIT: If you update from the old SGP, be sure to force a DLC update so that you're using my shiny updated DLC list!
If you're interested in contributing to the code, feel free to fork, modify, and push back with a pull request. If it looks reasonable, I'll merge your code into the master branch.
If you want me to add DLC, open an issue and add details (name, Steam store link, etc.).
Comment has been collapsed.