Crafting badge doesn't give me cards anymore

It's a very common bug that sometimes it says you got only 2 new items, but almost always you got the sale card as well.

If you are talking about sales badge, then yes it doesn't. Other badges though will. You might not get it right away (happened a lot in past sales) but you will eventually. Check the badge . It will most probably say x drops remaining